Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax requirement for interpolation in tests #465

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

berland
Copy link
Collaborator

@berland berland commented Oct 14, 2024

This is tuning of commit 4c66136

@reproduce_failure('6.114.1', b'AXicY2BgOGDAgAUc8L/eJVux8DqIKYAQFUBXx0gME9kEBXwmAABmjwjE') triggers a failure (ip_dist_std = ~1.13) which the accompanying plot reveals is perfectly fine.

This is tuning of commit 4c66136

@reproduce_failure('6.114.1', b'AXicY2BgOGDAgAUc8L/eJVux8DqIKYAQFUBXx0gME9kEBXwmAABmjwjE')
triggers a failure (ip_dist_std =  ~1.13) which the accompanying plot
reveals is perfectly fine.
@berland berland linked an issue Oct 14, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (7272760) to head (5110848).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          17       17           
  Lines        2725     2725           
=======================================
  Hits         2691     2691           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Found by trial and error

@berland berland merged commit 474e161 into equinor:main Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test, tests/test_utils_interpolation.py::test_interpolate_wo
3 participants